Merge request #121: Make sure all OTS specific files and directories are cleaned up

Previously some temporary files (e.g. images) were left uncleaned in the file system. Now all OTS specific temporary files and directories are deleted (at latest) when executing 'sudo /etc/init.d/ots-worker start'. Worker/conductor should handle all unexpected exceptions and delete all testrun specific files but e.g. in case of 'kill -9' there is no chance for doing the cleanup by the process itself. This addition makes sure that at least when restarting the workers there will be no temporary files left in the file system.

Now all OTS specific temporary files and directories are prefixed with 'ots-tmp-' and they are located (as before) in '/tmp'.

Files are deleted just before OTS workers are started when executing 'sudo /etc/init.d/ots-worker start'.

The cleanup script is installed in /usr/local/bin so it will be in PATH.

Also some refactorings included.

Enjoy.

Requested by: mileskin
Status: Closed
Source repository: ots-dev:cleanup-tmp-files
Target repository: ots:master
Created at: December 27th, 2011 11:59

Commits that would be merged:

Comments

Pushed new version 1

mileskin | 2011-12-27 11:59:36 UTC

→ State changed from Open to Closed

Thanks for your effort.
Merged to master.

villen | 2012-01-13 10:23:32 UTC

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/121

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/meego-quality-assurance/ots.git \
  refs/merge-requests/121

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/121

# To apply the changes to your branch:
git checkout master
git merge merge-requests/121
git push origin master

	6a6d4f6 Oskari Pirttikoski 5 months ago	use the configurable value
	c20653b Oskari Pirttikoski 5 months ago	new regex string assertion
	7d10941 Oskari Pirttikoski 5 months ago	assert path contents using regex
	2ba935d Oskari Pirttikoski 5 months ago	prefix ots temporary diroectories with ots-tmp-
	19e464b Oskari Pirttikoski 5 months ago	remove rootstrap temp dir after testing
	1c472cf Oskari Pirttikoski 5 months ago	rename test
	c4bc732 Oskari Pirttikoski 5 months ago	test that rootstrap path follows a certain pattern
	4c9654c Oskari Pirttikoski 5 months ago	new conf value for for temp file name prefix
	a2198a7 Oskari Pirttikoski 5 months ago	create the rootstrap dir in the configured temp dir
	6366444 Oskari Pirttikoski 5 months ago	use the new test name
	5493683 Oskari Pirttikoski 5 months ago	extract method for creating a temp file for rootstrap tar
	8df3fe1 Oskari Pirttikoski 5 months ago	store tar files into configured temp dir
	d8377bf Oskari Pirttikoski 5 months ago	use the configured prefix in tar file name
	1e94677 Oskari Pirttikoski 5 months ago	use the configured prefix in rootstrap dir name
	f003cd4 Oskari Pirttikoski 5 months ago	use the configured temp file prefix
	0975b9a Miki Leskinen 5 months ago	Add script for deleting all OTS specific temp files and directories

Reviewing merge request #121: Make sure all OTS specific files and directories are cleaned up

Commits that would be merged:

Comments
Include comments entered inline

Add a new comment:

Gitorious

Reviewing merge request #121: Make sure all OTS specific files and directories are cleaned up

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline