Reviewing merge request #5: improve cmake support, eliminate dead code

see commit msgs for details, two of commit also provide fix for meego bugs:
95be3a4: #15769
34d961d: #15768

The third one is about dead code because if-else sequence contains
duplicate "if cmake" entries and 2nd one con not be reached.

Commits that would be merged:

Version 1
  • Version 1
  • 7f41ae2
  • 95be3a4

    • use %cmake instead of make;

  • 34d961d

    • In case of builder set to cmake, emit "BuildRequires: cmake"

  • 9e9cf8f

    • removed what looks like dead code, as it it duplicate

Showing 7f41ae2-95be3a4

Comments

Pushed new version 1

avatar okartau | 2011-08-24 11:15:25 UTC

Thanks for your patch. For cmake support, we haven’t test it thoroughly before. Your patch is badly expected:)

One more question: have you tested the new cmake builder handling with enough meego packages?

avatar JF Ding | 2011-08-25 02:49:05 UTC

→ State changed from Open to Closed

merged, thanks

avatar JF Ding | 2011-10-10 10:04:27 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository